|
From: | Paolo Bonzini |
Subject: | Re: [PATCH 11/15] qtest: add a QOM object for qtest |
Date: | Mon, 7 Dec 2020 17:43:16 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 |
On 07/12/20 17:24, Igor Mammedov wrote:
+void qtest_server_init(const char *qtest_chrdev, const char *qtest_log, Error **errp) +{ + Chardev *chr; + + chr = qemu_chr_new("qtest", qtest_chrdev, NULL); + + if (chr == NULL) { + error_setg(errp, "Failed to initialize device for qtest: \"%s\"", + qtest_chrdev); + return; + } + + qtest_server_start(chr, qtest_log, errp);why not create qtest object here instead of trying to preserve old way, or create it directly at the place that calls qtest_server_init()?
Because I wasn't sure of where to put it in the QOM object tree. So I punted and left it for later.
Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |