[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v8 14/27] cpu: Remove unnecessary noop methods
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [RFC v8 14/27] cpu: Remove unnecessary noop methods |
Date: |
Sat, 5 Dec 2020 17:37:38 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 |
On 12/5/20 5:15 PM, Claudio Fontana wrote:
> From: Eduardo Habkost <ehabkost@redhat.com>
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> Signed-off-by: Claudio Fontana <cfontana@suse.de>
> ---
> hw/core/cpu.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/hw/core/cpu.c b/hw/core/cpu.c
> index 576fa1d7ba..994a12cb35 100644
> --- a/hw/core/cpu.c
> +++ b/hw/core/cpu.c
> @@ -199,15 +199,6 @@ static bool cpu_common_virtio_is_big_endian(CPUState
> *cpu)
> return target_words_bigendian();
> }
>
> -static void cpu_common_noop(CPUState *cpu)
> -{
> -}
> -
> -static bool cpu_common_exec_interrupt(CPUState *cpu, int int_req)
> -{
> - return false;
> -}
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
- [RFC v8 17/27] cpu: Move synchronize_from_tb() to tcg_ops, (continued)
- [RFC v8 17/27] cpu: Move synchronize_from_tb() to tcg_ops, Claudio Fontana, 2020/12/05
- [RFC v8 19/27] cpu: Move tlb_fill to tcg_ops, Claudio Fontana, 2020/12/05
- [RFC v8 12/27] tcg: make CPUClass.cpu_exec_* optional, Claudio Fontana, 2020/12/05
- [RFC v8 10/27] i386: move TCG cpu class initialization out of helper.c, Claudio Fontana, 2020/12/05
- [RFC v8 26/27] hw/core/cpu: call qemu_init_vcpu in cpu_common_realizefn, Claudio Fontana, 2020/12/05
- [RFC v8 23/27] accel: introduce AccelCPUClass extending CPUClass, Claudio Fontana, 2020/12/05
- [RFC v8 24/27] i386: split cpu accelerators from cpu.c, using AccelCPUClass, Claudio Fontana, 2020/12/05
- [RFC v8 27/27] cpu: introduce cpu_accel_instance_init, Claudio Fontana, 2020/12/05
- [RFC v8 14/27] cpu: Remove unnecessary noop methods, Claudio Fontana, 2020/12/05
- Re: [RFC v8 14/27] cpu: Remove unnecessary noop methods,
Philippe Mathieu-Daudé <=
- [RFC v8 13/27] tcg: Make CPUClass.debug_excp_handler optional, Claudio Fontana, 2020/12/05
- [RFC v8 20/27] cpu: Move debug_excp_handler to tcg_ops, Claudio Fontana, 2020/12/05
- [RFC v8 16/27] accel/tcg: split TCG-only code from cpu_exec_realizefn, Claudio Fontana, 2020/12/05
- [RFC v8 18/27] cpu: Move cpu_exec_* to tcg_ops, Claudio Fontana, 2020/12/05
- [RFC v8 21/27] accel: extend AccelState and AccelClass to user-mode, Claudio Fontana, 2020/12/05
- [RFC v8 25/27] cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn, Claudio Fontana, 2020/12/05
- [RFC v8 22/27] accel: replace struct CpusAccel with AccelOpsClass, Claudio Fontana, 2020/12/05
- Re: [RFC v8 00/22] i386 cleanup, Claudio Fontana, 2020/12/05