[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 7/9] target/mips: Extract msa_translate_init() from mips_tcg_
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 7/9] target/mips: Extract msa_translate_init() from mips_tcg_init() |
|
Date: |
Fri, 4 Dec 2020 18:23:31 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 |
On 12/4/20 5:30 PM, Richard Henderson wrote:
> On 12/2/20 12:44 PM, Philippe Mathieu-Daudé wrote:
>> Extract the logic initialization of the MSA registers from
>> the generic initialization.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> target/mips/translate.c | 35 ++++++++++++++++++++---------------
>> 1 file changed, 20 insertions(+), 15 deletions(-)
>
> Why?
msa_wr_d[] registers are only used by MSA, so in the next series
that allows me to move the 'static msa_wr_d[]' in msa_translate.c,
without having to declare them global with extern.
>
>> - fpu_f64[i] = tcg_global_mem_new_i64(cpu_env, off, msaregnames[i *
>> 2]);
>> + fpu_f64[i] = tcg_global_mem_new_i64(cpu_env, off, fregnames[i]);
>
> Maybe fold this back to the previous patch?
Certainly ;)
>
>
> r~
>
[PATCH 8/9] target/mips: Remove CPUMIPSState* argument from gen_msa*() methods, Philippe Mathieu-Daudé, 2020/12/02
[PATCH 9/9] target/mips: Explode gen_msa_branch() as gen_msa_BxZ_V/BxZ(), Philippe Mathieu-Daudé, 2020/12/02
Re: [PATCH 0/9] target/mips: Simplify MSA TCG logic, Jiaxun Yang, 2020/12/02
Re: [PATCH 0/9] target/mips: Simplify MSA TCG logic, Jiaxun Yang, 2020/12/02