qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] tests/acceptance: test hot(un)plug of ccw devices


From: Wainer dos Santos Moschetta
Subject: Re: [PATCH v2] tests/acceptance: test hot(un)plug of ccw devices
Date: Fri, 4 Dec 2020 11:05:34 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0

Hi,

On 12/4/20 9:14 AM, Cornelia Huck wrote:
Hotplug a virtio-net-ccw device, and then hotunplug it again.

Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---

v1->v2:
- switch device id
- clear out dmesg before looking for CRW messages

---
  tests/acceptance/machine_s390_ccw_virtio.py | 16 ++++++++++++++++
  1 file changed, 16 insertions(+)

diff --git a/tests/acceptance/machine_s390_ccw_virtio.py 
b/tests/acceptance/machine_s390_ccw_virtio.py
index 53b8484f8f9c..83c00190621b 100644
--- a/tests/acceptance/machine_s390_ccw_virtio.py
+++ b/tests/acceptance/machine_s390_ccw_virtio.py
@@ -97,3 +97,19 @@ class S390CCWVirtioMachine(Test):
          exec_command_and_wait_for_pattern(self,
                                            'cat 
/sys/bus/pci/devices/000a\:00\:00.0/function_id',
                                            '0x0000000c')
+        # add another device
+        exec_command_and_wait_for_pattern(self, 'dmesg -c', ' ')


The problem is that `dmesg -c` will fail if you run the test with unprivileged user.

- Wainer

+        self.vm.command('device_add', driver='virtio-net-ccw',
+                        devno='fe.0.4711', id='net_4711')
+        exec_command_and_wait_for_pattern(self, 'dmesg', 'CRW')
+        exec_command_and_wait_for_pattern(self, 'ls /sys/bus/ccw/devices/',
+                                          '0.0.4711')
+        # and detach it again
+        exec_command_and_wait_for_pattern(self, 'dmesg -c', ' ')
+        self.vm.command('device_del', id='net_4711')
+        self.vm.event_wait(name='DEVICE_DELETED',
+                           match={'data': {'device': 'net_4711'}})
+        exec_command_and_wait_for_pattern(self, 'dmesg', 'CRW')
+        exec_command_and_wait_for_pattern(self,
+                                          'ls /sys/bus/ccw/devices/0.0.4711',
+                                          'No such file or directory')




reply via email to

[Prev in Thread] Current Thread [Next in Thread]