RE: [PATCH v14 1/4] usb: Add versal-usb2-ctrl-regs module

[Sai Pavan Boddu]

Hi Peter,
> -----Original Message-----
> From: Peter Maydell <peter.maydell@linaro.org>
> Sent: Tuesday, December 1, 2020 4:53 PM
> To: Sai Pavan Boddu <saipava@xilinx.com>
> Cc: Markus Armbruster <armbru@redhat.com>; Marc-André Lureau
> <marcandre.lureau@redhat.com>; Paolo Bonzini <pbonzini@redhat.com>;
> Gerd Hoffmann <kraxel@redhat.com>; Edgar Iglesias <edgari@xilinx.com>;
> Francisco Eduardo Iglesias <figlesia@xilinx.com>; Alistair Francis
> <alistair.francis@wdc.com>; Eduardo Habkost <ehabkost@redhat.com>; Ying
> Fang <fangying1@huawei.com>; Philippe Mathieu-Daudé
> <philmd@redhat.com>; Vikram Garhwal <fnuv@xilinx.com>; Paul Zimmerman
> <pauldzim@gmail.com>; Sai Pavan Boddu <saipava@xilinx.com>; QEMU
> Developers <qemu-devel@nongnu.org>
> Subject: Re: [PATCH v14 1/4] usb: Add versal-usb2-ctrl-regs module
> 
> On Tue, 1 Dec 2020 at 08:34, Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>
> wrote:
> >
> > This module emulates control registers of versal usb2 controller, this
> > is added just to make guest happy. In general this module would
> > control the phy-reset signal from usb controller, data coherency of
> > the transactions, signals the host system errors received from controller.
> >
> > Signed-off-by: Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>
> > Signed-off-by: Vikram Garhwal <fnu.vikram@xilinx.com>
> > Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> > ---
> >  hw/usb/meson.build                          |   1 +
> >  hw/usb/xlnx-versal-usb2-ctrl-regs.c         | 229
> ++++++++++++++++++++++++++++
> >  include/hw/usb/xlnx-versal-usb2-ctrl-regs.h |  45 ++++++
> >  3 files changed, 275 insertions(+)
> >  create mode 100644 hw/usb/xlnx-versal-usb2-ctrl-regs.c
> >  create mode 100644 include/hw/usb/xlnx-versal-usb2-ctrl-regs.h
> 
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
[Sai Pavan Boddu] Thanks for the review.

Regards,
Sai Pavan
> 
> thanks
> -- PMM