RE: [RFC PATCH v5 18/33] Hexagon (target/hexagon/imported) arch import

[Taylor Simpson]

> -----Original Message-----
> From: Alessandro Di Federico <ale.qemu@rev.ng>
> Sent: Thursday, November 19, 2020 4:54 PM
> To: Taylor Simpson <tsimpson@quicinc.com>
> Cc: qemu-devel@nongnu.org; richard.henderson@linaro.org;
> at.org@qualcomm.com; laurent@vivier.eu; Brian Cain <bcain@quicinc.com>
> Subject: Re: [RFC PATCH v5 18/33] Hexagon (target/hexagon/imported) arch
> import
>
> On Thu, 29 Oct 2020 19:08:24 -0500
> Taylor Simpson <tsimpson@quicinc.com> wrote:
>
> > +Q6INSN(C2_any8,"Pd4=any8(Ps4)",ATTRIBS(A_CRSLOT23),
> > +"Logical ANY of low 8 predicate bits",
> > +{ PsV ? (PdV=0xff) : (PdV=0x00); })
>
> I understand these files are supposed to stay unchanged, but handling
> assignments as expressions as opposed to statements would complicate
> our parser in a non-negligible way.
>
> Would it be possible to turn this (and other similar situations) into:
>
>     { PdV = PsV ? (0xff) : (0x00); }


Even though this one is obvious, I'm not ready to open the door to changes to 
the imported files.  We need to have a conversation with the owners on a long 
term strategy for keeping these files in sync.

I'll make the other two changes you suggested and resubmit the patch series.  
Since we've been through several reviews, I'll remove the "RFC" this time.


Thanks,
Taylor