[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] docs/devel/writing-qmp-commands.txt: Fix docs
From: |
Eric Blake |
Subject: |
Re: [PATCH] docs/devel/writing-qmp-commands.txt: Fix docs |
Date: |
Tue, 1 Dec 2020 14:18:56 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 |
On 12/1/20 8:33 AM, Zihao Chang wrote:
> Fix the example of add qmp hello-world example.
> Without ":", make will report error:
> ../qapi/misc.json:573:2: line should end with ':'
>
> Signed-off-by: Zihao Chang <changzihao1@huawei.com>
> ---
> docs/devel/writing-qmp-commands.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/docs/devel/writing-qmp-commands.txt
> b/docs/devel/writing-qmp-commands.txt
> index 46a6c48683..28984686c9 100644
> --- a/docs/devel/writing-qmp-commands.txt
> +++ b/docs/devel/writing-qmp-commands.txt
> @@ -243,7 +243,7 @@ There are many examples of such documentation in the
> schema file already, but
> here goes "hello-world"'s new entry for qapi/misc.json:
>
> ##
> -# @hello-world
> +# @hello-world:
> #
> # Print a client provided string to the standard output stream.
> #
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org