Re: [PATCH v2 0/6] migration: Multi-thread compression method support

[Zeyu Jin]

On 2020/12/1 0:42, Eric Blake wrote:
> On 11/27/20 3:36 AM, Zeyu Jin wrote:
> 
> Meta-comment: you appear to be having problems threading your series;
> I've now seen three separate cover letters (RFC v1, v2 with no subject,
> v2 with subject) and two series where each patch was a separate thread.
> It is difficult to follow which messages are related when reading in a
> mail client that sorts by most-recently-active thread first.  You may
> want to investigate why your threading is not working, although I'd wait
> to send v3 until you have actual changes to incorporate.
> 

Thank you for noticing that. It`s my mistake when sending patches.
Everything will be fine in v3.

>> Currently we have both multi-thread compression and multifd to optimize
>> live migration in Qemu. Mulit-thread compression deals with the situation
>> where network bandwith is limited but cpu resource adequate. Multifd instead
> 
> Not that typos in the cover letter matter, but this should be 'bandwidth'
>

Yes, I will fix that.

>> aims to take full advantage of network bandwith. Moreover it supports both
>> zlib and zstd compression on each channel.
>>
>> In this patch series, we did some code refactoring on multi-thread 
>> compression
>> live migration and bring zstd compression method support for it.
>>
>> Below is the test result of multi-thread compression live migration
>> with different compress methods. Test result shows that zstd outperforms
>> zlib by about 70%.
>>
>