Re: [PATCH] python 3.5 compatibility

[Kevin Wolf]

Am 27.11.2020 um 19:36 hat Enrico Weigelt, metux IT consult geschrieben:
> Several stable distros are still on python-3.5, so qemu cannot be
> built there, w/o backporting the whole python stack. In order to
> make qemu build there, make it running w/ python-3.5. The changes
> are mostly removing the new type annotations (which, IMHO, just
> serve for documentation purpose)

While type hints are valuable documentation, they are more than just
that. They help to find and prevent avoidable bugs in the code. We are
actively in the process of adding them to everything in the QAPI
generator to improve maintainability rather than removing them.

Kevin

> and replacing f-strings by classic
> string formatting.
> 
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
> ---
>  configure                          |  4 +--
>  scripts/block-coroutine-wrapper.py | 56 
> ++++++++++++++++++--------------------
>  scripts/qapi/commands.py           |  2 +-
>  scripts/qapi/common.py             |  2 +-
>  scripts/qapi/events.py             |  2 +-
>  scripts/qapi/gen.py                | 10 +++----
>  scripts/qapi/main.py               |  6 ++--
>  scripts/qapi/schema.py             |  2 +-
>  scripts/qapi/source.py             | 10 +++----
>  9 files changed, 46 insertions(+), 48 deletions(-)