[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] gitlab-ci.yml: Add openSUSE Leap 15.2 for gitlab CI/CD
From: |
Thomas Huth |
Subject: |
Re: [PATCH v2] gitlab-ci.yml: Add openSUSE Leap 15.2 for gitlab CI/CD |
Date: |
Mon, 30 Nov 2020 09:28:42 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 |
On 30/11/2020 05.26, Cho, Yu-Chen wrote:
> v2:
> Drop some package from dockerfile to make docker image more light.
>
> v1:
> Add build-system-opensuse jobs and opensuse-leap.docker dockerfile.
> Use openSUSE Leap 15.2 container image in the gitlab-CI.
>
> Signed-off-by: Cho, Yu-Chen <acho@suse.com>
> ---
> .gitlab-ci.d/containers.yml | 5 ++
> .gitlab-ci.yml | 30 +++++++++++
> tests/docker/dockerfiles/opensuse-leap.docker | 54 +++++++++++++++++++
> 3 files changed, 89 insertions(+)
> create mode 100644 tests/docker/dockerfiles/opensuse-leap.docker
Hi!
Sorry, I was too busy to reply last week ... you could also simply ping on
the v2 that you've sent last week, but anyway, let's now continue discussion
here. I gave it a try, and runtime is much better now, indeed:
https://gitlab.com/huth/qemu/-/jobs/868942587
So:
Tested-by: Thomas Huth <thuth@redhat.com>
Patch looks also fine to me, you should just not put the version log above
the "---" but below, otherwise the version log will show up in the final
patch when it gets picked up with "git am".
No need to resend just because of this, though, I can fix that when picking
up the patch. I'll queue for my testing tree and send it once the hard
freeze is over.
Thomas