[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] target/nios2: Move nios2_check_interrupts() into target/
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 2/2] target/nios2: Move nios2_check_interrupts() into target/nios2 |
|
Date: |
Fri, 27 Nov 2020 20:32:09 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 |
On 11/27/20 8:12 PM, Peter Maydell wrote:
> The function nios2_check_interrupts)() looks only at CPU-internal
> state; it belongs in target/nios2, not hw/nios2. Move it into the
> same file as its only caller, so it can just be local to that file.
>
> This removes the only remaining code from cpu_pic.c, so we can delete
> that file entirely.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> target/nios2/cpu.h | 2 --
> hw/nios2/cpu_pic.c | 36 ------------------------------------
> target/nios2/op_helper.c | 9 +++++++++
> hw/nios2/meson.build | 2 +-
> 4 files changed, 10 insertions(+), 39 deletions(-)
> delete mode 100644 hw/nios2/cpu_pic.c
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>