[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 13/36] vl: move semihosting command line fallback to qemu_ini

From: Igor Mammedov
Subject: Re: [PATCH 13/36] vl: move semihosting command line fallback to qemu_init_board
Date: Fri, 27 Nov 2020 13:12:45 +0100

On Fri, 27 Nov 2020 12:22:51 +0100
Paolo Bonzini <pbonzini@redhat.com> wrote:

> On 27/11/20 11:31, Igor Mammedov wrote:
> >> Yes, calling it around machine initialization time is also a
> >> possibility.  I just wanted to get rid of it in code that I'm actually
> >> looking at.:)  
> > I'd prefer it being moved close to CLI parsing,
> > in a place where other _early call go.
> > 
> > We probably want qemu_init_board() being clear of not really needed clutter.
> >   
> Fair enough, I'd put -semihosting-config in the same bucket as 
> -m/-boot/-smp (machine configuration that isn't in -M) so I'll move it 
> together with them.
it might be machine code, but I didn't see anything that depends
on machine in there that's why I've suggested to move it right after
we parse CLI options (i.e. as early as possible) to keep the rest of
code cleaner

> Paolo

reply via email to

[Prev in Thread] Current Thread [Next in Thread]