[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 05/13] qemu-plugin.h: remove GCC < 4
From: |
Peter Maydell |
Subject: |
Re: [PATCH v2 05/13] qemu-plugin.h: remove GCC < 4 |
Date: |
Thu, 26 Nov 2020 11:57:14 +0000 |
On Thu, 26 Nov 2020 at 11:30, <marcandre.lureau@redhat.com> wrote:
>
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Since commit efc6c07 ("configure: Add a test for the minimum compiler
> version"), QEMU explicitely depends on GCC >= 4.8.
>
> (clang >= 3.8 advertizes itself as GCC >= 4.2 compatible)
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> include/qemu/qemu-plugin.h | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
This is an interesting case, because it's a header intended
for external use (people compiling plugins), not part of
QEMU proper. I don't know whether we want to impose the
same clang/gcc requirements on plugin builders, though it's
probably not a bad idea to do so. Alex ?
thanks
-- PMM
[PATCH v2 06/13] tests: remove GCC < 4 fallbacks, marcandre . lureau, 2020/11/26
[PATCH v2 07/13] virtiofsd: replace _Static_assert with QEMU_BUILD_BUG_ON, marcandre . lureau, 2020/11/26
[PATCH v2 08/13] compiler.h: explicit case for Clang printf attribute, marcandre . lureau, 2020/11/26
[PATCH v2 09/13] audio: remove GNUC & MSVC check, marcandre . lureau, 2020/11/26