[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 0/5] Final (?) batch of misc patches for QEMU 5.2
From: |
no-reply |
Subject: |
Re: [PULL 0/5] Final (?) batch of misc patches for QEMU 5.2 |
Date: |
Thu, 26 Nov 2020 00:12:43 -0800 (PST) |
Patchew URL:
20201126075921.3116321-1-pbonzini@redhat.com/">https://patchew.org/QEMU/20201126075921.3116321-1-pbonzini@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20201126075921.3116321-1-pbonzini@redhat.com
Subject: [PULL 0/5] Final (?) batch of misc patches for QEMU 5.2
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20201126075921.3116321-1-pbonzini@redhat.com ->
patchew/20201126075921.3116321-1-pbonzini@redhat.com
Switched to a new branch 'test'
b995d60 nsis: Fix build for 64 bit installer
9e5be66 target/i386: fix operand order for PDEP and PEXT
7fd39a5 tests/docker, tests/vm: remove setuptools from images
a10f1b0 configure: remove python pkg_resources check
9fa2f63 meson: use dependency() to find libjpeg
=== OUTPUT BEGIN ===
1/5 Checking commit 9fa2f638020f (meson: use dependency() to find libjpeg)
2/5 Checking commit a10f1b02f345 (configure: remove python pkg_resources check)
3/5 Checking commit 7fd39a5eb4e0 (tests/docker, tests/vm: remove setuptools
from images)
4/5 Checking commit 9e5be6648e96 (target/i386: fix operand order for PDEP and
PEXT)
WARNING: Block comments use a leading /* on a separate line
#29: FILE: target/i386/translate.c:3939:
+ /* Note that by zero-extending the source operand, we
WARNING: Block comments use a leading /* on a separate line
#46: FILE: target/i386/translate.c:3957:
+ /* Note that by zero-extending the source operand, we
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#73:
new file mode 100644
ERROR: open brace '{' following function declarations go on the next line
#82: FILE: tests/tcg/i386/test-i386-bmi2.c:5:
+int main(int argc, char *argv[]) {
WARNING: line over 80 characters
#93: FILE: tests/tcg/i386/test-i386-bmi2.c:16:
+ asm volatile ("pdepq %2, %1, %0" : "=r"(result64) : "r"(result64),
"m"(mask));
WARNING: line over 80 characters
#96: FILE: tests/tcg/i386/test-i386-bmi2.c:19:
+ asm volatile ("pextq %2, %1, %0" : "=r"(result64) : "r"(-1ull),
"m"(mask));
WARNING: line over 80 characters
#99: FILE: tests/tcg/i386/test-i386-bmi2.c:22:
+ asm volatile ("pdepq %2, %1, %0" : "=r"(result64) : "r"(-1ull),
"m"(mask));
WARNING: line over 80 characters
#103: FILE: tests/tcg/i386/test-i386-bmi2.c:26:
+ asm volatile ("pextl %2, %k1, %k0" : "=r"(result32) : "r"(ehlo),
"m"(mask));
WARNING: line over 80 characters
#106: FILE: tests/tcg/i386/test-i386-bmi2.c:29:
+ asm volatile ("pdepl %2, %k1, %k0" : "=r"(result32) : "r"(result32),
"m"(mask));
WARNING: line over 80 characters
#109: FILE: tests/tcg/i386/test-i386-bmi2.c:32:
+ asm volatile ("pextl %2, %k1, %k0" : "=r"(result32) : "r"(-1ull),
"m"(mask));
WARNING: line over 80 characters
#112: FILE: tests/tcg/i386/test-i386-bmi2.c:35:
+ asm volatile ("pdepl %2, %k1, %k0" : "=r"(result32) : "r"(-1ull),
"m"(mask));
total: 1 errors, 10 warnings, 81 lines checked
Patch 4/5 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/5 Checking commit b995d60446aa (nsis: Fix build for 64 bit installer)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
20201126075921.3116321-1-pbonzini@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20201126075921.3116321-1-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
- [PULL 0/5] Final (?) batch of misc patches for QEMU 5.2, Paolo Bonzini, 2020/11/26
- [PULL 2/5] configure: remove python pkg_resources check, Paolo Bonzini, 2020/11/26
- [PULL 3/5] tests/docker, tests/vm: remove setuptools from images, Paolo Bonzini, 2020/11/26
- [PULL 1/5] meson: use dependency() to find libjpeg, Paolo Bonzini, 2020/11/26
- [PULL 4/5] target/i386: fix operand order for PDEP and PEXT, Paolo Bonzini, 2020/11/26
- [PULL 5/5] nsis: Fix build for 64 bit installer, Paolo Bonzini, 2020/11/26
- Re: [PULL 0/5] Final (?) batch of misc patches for QEMU 5.2,
no-reply <=
- Re: [PULL 0/5] Final (?) batch of misc patches for QEMU 5.2, Peter Maydell, 2020/11/26
- Re: [PULL 0/5] Final (?) batch of misc patches for QEMU 5.2, Peter Maydell, 2020/11/26