[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-5.2] nsis: Fix build for 64 bit installer

From: Stefan Weil
Subject: Re: [PATCH for-5.2] nsis: Fix build for 64 bit installer
Date: Wed, 25 Nov 2020 21:59:48 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.5.0

Am 25.11.20 um 20:28 schrieb Peter Maydell:

On Wed, 25 Nov 2020 at 19:23, Stefan Weil <sw@weilnetz.de> wrote:
Pass cpu instead of cpu_family to the NSIS installer script.

That script checks for "x86_64" which is the cpu value,
while cpu_family is "x86".

Signed-off-by: Stefan Weil <sw@weilnetz.de>
  meson.build | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Very unfortunate that this has only surfaced after rc3,
which should in theory be the cutoff point for 5.2 changes.
Is it possible to get something into the CI/make check
so that we find Windows installer issues sooner?

-- PMM

I am afraid there are more open issues for QEMU on Windows. They can be fixed in 5.2.1, so don't hesitate to finish 5.2.0.

The Meson based build sets bindir=/qemu/. which does not work correctly in get_relocated_path().

Finding such issues would require a CI environment which not only builds QEMU for Windows, but also runs the results. Some basic tests could be done on Linux using Wine, more advanced tests would require a real Windows host.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]