Re: [PATCH] hmp: Changed hmp_netdev_add() using qmp_marshal_netdev_add()

[Markus Armbruster]

Yuri Benditovich <yuri.benditovich@daynix.com> writes:

> On Tue, Nov 24, 2020 at 5:46 PM Markus Armbruster <armbru@redhat.com> wrote:
[...]
>> The CLI accumulates -netdev in option group "netdev".  It has to, or
>> else -writeconfig doesn't work.
>>
>> Before commit 08712fcb85 "net: Track netdevs in NetClientState rather
>> than QemuOpt", netdev_add added to the option group, and netdev_del
>> removed from it, both for HMP and QMP.  Thus, every netdev had a
>> corresponding QemuOpts in this option group.
>>
>> Commit 08712fcb85 dropped this for QMP netdev_add and both netdev_del.
>> Now a netdev has a corresponding QemuOpts only when it was created with
>> CLI or HMP.  Two issues:
>>
>> * QMP netdev_add loses its "no duplicate ID" check.
>>
>>   My change to net_init_client1() fixes this.
>>
>> * Both netdev_add can leave QemuOpts behind, breaking HMP netdev_add.
>>
>>   My change to qmp_netdev_del() fixes this.
>>
>> Questions?
>>
> No questions, looking forward for the final patch
> Thanks

Posted:

    Subject: [PATCH 0/1] net: Fix handling of id in netdev_add and netdev_del
    Message-Id: <20201125100220.50251-1-armbru@redhat.com>

Thanks for your help, guys, I appreciate it!