[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 2/7] tests: add prefixes to the bare mkdtemp calls
From: |
Alex Bennée |
Subject: |
[PULL 2/7] tests: add prefixes to the bare mkdtemp calls |
Date: |
Mon, 23 Nov 2020 11:25:13 +0000 |
The first step to debug a thing is to know what created the thing in
the first place. Add some prefixes so random tmpdir's have something
grep in the code.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20201117173635.29101-3-alex.bennee@linaro.org>
diff --git a/python/qemu/machine.py b/python/qemu/machine.py
index 6420f01bed..64d966aeeb 100644
--- a/python/qemu/machine.py
+++ b/python/qemu/machine.py
@@ -303,7 +303,8 @@ class QEMUMachine:
return args
def _pre_launch(self) -> None:
- self._temp_dir = tempfile.mkdtemp(dir=self._test_dir)
+ self._temp_dir = tempfile.mkdtemp(prefix="qemu-machine-",
+ dir=self._test_dir)
self._qemu_log_path = os.path.join(self._temp_dir, self._name + ".log")
self._qemu_log_file = open(self._qemu_log_path, 'wb')
diff --git a/tests/acceptance/avocado_qemu/__init__.py
b/tests/acceptance/avocado_qemu/__init__.py
index 4cda037187..307020be45 100644
--- a/tests/acceptance/avocado_qemu/__init__.py
+++ b/tests/acceptance/avocado_qemu/__init__.py
@@ -171,7 +171,8 @@ class Test(avocado.Test):
self.cancel("No QEMU binary defined or found in the build tree")
def _new_vm(self, *args):
- vm = QEMUMachine(self.qemu_bin, sock_dir=tempfile.mkdtemp())
+ sd = tempfile.mkdtemp(prefix="avo_qemu_sock_")
+ vm = QEMUMachine(self.qemu_bin, sock_dir=sd)
if args:
vm.add_args(*args)
return vm
--
2.20.1
- [PULL for 5.2-rc3 0/7] various CI cleanups (scripts, avocado, gitlab), Alex Bennée, 2020/11/23
- [PULL 1/7] scripts/ci: clean up default args logic a little, Alex Bennée, 2020/11/23
- [PULL 2/7] tests: add prefixes to the bare mkdtemp calls,
Alex Bennée <=
- [PULL 4/7] gitlab: move remaining x86 check-tcg targets to gitlab, Alex Bennée, 2020/11/23
- [PULL 3/7] tests/avocado: clean-up socket directory after run, Alex Bennée, 2020/11/23
- [PULL 5/7] tests/docker: Install liblttng-ust-dev package in Ubuntu 20.04 image, Alex Bennée, 2020/11/23
- [PULL 6/7] gitlab-ci: Move trace backend tests across to gitlab, Alex Bennée, 2020/11/23
- [PULL 7/7] .cirrus.yml: bump timeout period for MacOS builds, Alex Bennée, 2020/11/23
- Re: [PULL for 5.2-rc3 0/7] various CI cleanups (scripts, avocado, gitlab), Peter Maydell, 2020/11/23