Re: [PATCH 07/26] target/mips: Extract DSP translation routines

[Richard Henderson]

On 11/20/20 1:08 PM, Philippe Mathieu-Daudé wrote:
> Extract 2150 lines from the huge translate.c to a new file,
> 'mod-mips-dsp_translate.c.inc'. As there are too many inter-
> dependencies we don't compile it as another object, but
> keep including it in the big translate.o. We gain in code
> maintainability.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  target/mips/mod-mips-dsp_helper.c        |    2 +
>  target/mips/translate.c                  | 2150 +--------------------
>  target/mips/mod-mips-dsp_translate.c.inc | 2158 ++++++++++++++++++++++
>  3 files changed, 2164 insertions(+), 2146 deletions(-)
>  create mode 100644 target/mips/mod-mips-dsp_translate.c.inc

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

> +++ b/target/mips/mod-mips-dsp_helper.c
> @@ -15,6 +15,8 @@
>   *
>   * You should have received a copy of the GNU Lesser General Public
>   * License along with this library; if not, see 
> <http://www.gnu.org/licenses/>.
> + *
> + * SPDX-License-Identifier: LGPL-2.1-or-later

Needs to get folded back to patch 5.

r~