qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Regressions in build process introduced since August


From: Stefan Weil
Subject: Re: Regressions in build process introduced since August
Date: Sat, 21 Nov 2020 11:25:53 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.4.3

Hi,

I just noticed another regression:

A cross build targeting Windows no longer detects VNC JPEG support. Using pkg-config like in the patch below would fix that (and also works for native builds on Debian GNU Linux).

Maybe the current find_library ignores --extra-cflags and --extra-ldflags? That would explain why it fails to find the required header and library files. Other checks would fail then, too.

Regards,

Stefan


--- a/meson.build
+++ b/meson.build
@@ -649,9 +649,8 @@ if get_option('vnc').enabled()
   vnc = declare_dependency() # dummy dependency
   png = dependency('libpng', required: get_option('vnc_png'),
                    method: 'pkg-config', static: enable_static)
-  jpeg = cc.find_library('jpeg', has_headers: ['jpeglib.h'],
-                         required: get_option('vnc_jpeg'),
-                         static: enable_static)
+  jpeg = dependency('libpng', required: get_option('vnc_jpeg'),
+                   method: 'pkg-config', static: enable_static)
   sasl = cc.find_library('sasl2', has_headers: ['sasl/sasl.h'],
                          required: get_option('vnc_sasl'),
                          static: enable_static)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]