|
From: | Paolo Bonzini |
Subject: | Re: [PATCH 28/29] vl: remove separate preconfig main_loop |
Date: | Fri, 20 Nov 2020 17:39:09 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 |
On 20/11/20 17:26, Igor Mammedov wrote:
+ if (!preconfig_requested) { + qmp_x_exit_preconfig(&error_fatal); + } + qemu_init_displays();given that qemu_init_displays() were called in both cases, shouldn't it be called unconditionally at [1]?
Yes, makes sense. In fact, it would be nicer to also call accel_setup_post(current_machine); os_setup_post(); before x_exit_preconfig, but it's left for another day. Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |