[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] usb: fix kconfig for usb-xhci-sysbus
From: |
Bruce Rogers |
Subject: |
Re: [PATCH v2] usb: fix kconfig for usb-xhci-sysbus |
Date: |
Fri, 20 Nov 2020 09:27:06 -0700 |
User-agent: |
Evolution 3.36.5 |
On Fri, 2020-11-20 at 10:45 -0500, Paolo Bonzini wrote:
> Remove the "default y" for USB_XHCI_SYSBUS because
> sysbus devices are not user creatable; boards that use them will
> specify them manually with "imply" or "select" clauses.
>
> It would be nice to keep the ability to remove PCIe and USB from
> microvm,
> since thos can be disabled on the command line and therefore should
> not
> be included if QEMU is configured --without-default-devices. However
> it's too late for 5.2 to figure out a place for the DSDT creation
> code.
>
> Reported-by: Bruce Rogers <brogers@suse.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> hw/usb/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig
> index 3b07d9cf68..7fbae18bc8 100644
> --- a/hw/usb/Kconfig
> +++ b/hw/usb/Kconfig
> @@ -47,7 +47,6 @@ config USB_XHCI_NEC
>
> config USB_XHCI_SYSBUS
> bool
> - default y
> select USB_XHCI
>
> config USB_MUSB
Tested-by: Bruce Rogers <brogers@suse.com>