[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v5 18/33] Hexagon (target/hexagon/imported) arch import
From: |
Alessandro Di Federico |
Subject: |
Re: [RFC PATCH v5 18/33] Hexagon (target/hexagon/imported) arch import |
Date: |
Thu, 19 Nov 2020 23:53:41 +0100 |
On Thu, 29 Oct 2020 19:08:24 -0500
Taylor Simpson <tsimpson@quicinc.com> wrote:
> +Q6INSN(C2_any8,"Pd4=any8(Ps4)",ATTRIBS(A_CRSLOT23),
> +"Logical ANY of low 8 predicate bits",
> +{ PsV ? (PdV=0xff) : (PdV=0x00); })
I understand these files are supposed to stay unchanged, but handling
assignments as expressions as opposed to statements would complicate
our parser in a non-negligible way.
Would it be possible to turn this (and other similar situations) into:
{ PdV = PsV ? (0xff) : (0x00); }
You can easily spot these situations with a shot of:
git grep -E '\?[^:]*=' target/hexagon/
They are all like this, the left-hand side of the assignment is always
the same in both the true and false branch of the ternary operator.
--
Alessandro Di Federico
rev.ng
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [RFC PATCH v5 18/33] Hexagon (target/hexagon/imported) arch import,
Alessandro Di Federico <=