[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 0/8] qom: Use qlit to represent property defaults

From: Paolo Bonzini
Subject: Re: [PATCH v2 0/8] qom: Use qlit to represent property defaults
Date: Thu, 19 Nov 2020 19:25:15 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0

On 19/11/20 18:55, Eduardo Habkost wrote:
On Thu, Nov 19, 2020 at 06:23:30PM +0100, Paolo Bonzini wrote:
On 19/11/20 18:13, Eduardo Habkost wrote:
What's left?
Enums.  Enums properties are a mess to implement, and I plan to
tackle them later.

On all other cases, the external representation of the property
value is similar to the internal representation.  In the case of
enums, the external representation is a string, but the internal
representation is an integer.

I would have expected a string QLit to work with enums, is there a reason
why it doesn't?

It would work, but it would be more inconvenient for callers.
Right now they use the C enum constant instead of a string.

It matches what you have to do already for compat props, so it's not a big deal. I would say just use strings.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]