[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/8] qnum: qnum_value_is_equal() function
From: |
Eduardo Habkost |
Subject: |
Re: [PATCH v2 4/8] qnum: qnum_value_is_equal() function |
Date: |
Thu, 19 Nov 2020 13:24:03 -0500 |
On Thu, Nov 19, 2020 at 11:27:40AM +0100, Markus Armbruster wrote:
[...]
> > +bool qnum_is_equal(const QObject *x, const QObject *y)
> > +{
> > + const QNum *qnum_x = qobject_to(QNum, x);
> > + const QNum *qnum_y = qobject_to(QNum, y);
>
> Humor me: blank line between declarations and statements, please.
I can do it. But why do you prefer it that way?
>
> > + return qnum_value_is_equal(&qnum_x->value, &qnum_y->value);
> > +}
> > +
> > /**
> > * qnum_destroy_obj(): Free all memory allocated by a QNum object
> > *
--
Eduardo
- Re: [PATCH v2 3/8] qnum: QNumValue type for QNum value literals, (continued)
[PATCH v2 4/8] qnum: qnum_value_is_equal() function, Eduardo Habkost, 2020/11/16
Re: [PATCH v2 4/8] qnum: qnum_value_is_equal() function, Markus Armbruster, 2020/11/19
[PATCH v2 7/8] qom: Make object_property_set_default() public, Eduardo Habkost, 2020/11/16
[PATCH v2 8/8] qom: Use qlit to represent property defaults, Eduardo Habkost, 2020/11/16
[PATCH v2 6/8] qlit: qlit_type() function, Eduardo Habkost, 2020/11/16