qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] virtio-blk: seg_max do not subtract 2 if host has VIRTIO_RIN


From: no-reply
Subject: Re: [PATCH] virtio-blk: seg_max do not subtract 2 if host has VIRTIO_RING_F_INDIRECT_DESC feature
Date: Thu, 19 Nov 2020 01:06:44 -0800 (PST)

Patchew URL: 
20201119085437.5333-1-RockCui-oc@zhaoxin.com/">https://patchew.org/QEMU/20201119085437.5333-1-RockCui-oc@zhaoxin.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20201119085437.5333-1-RockCui-oc@zhaoxin.com
Subject: [PATCH] virtio-blk: seg_max do not subtract 2 if host has 
VIRTIO_RING_F_INDIRECT_DESC feature

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20201119085437.5333-1-RockCui-oc@zhaoxin.com -> 
patchew/20201119085437.5333-1-RockCui-oc@zhaoxin.com
Switched to a new branch 'test'
166948e virtio-blk: seg_max do not subtract 2 if host has 
VIRTIO_RING_F_INDIRECT_DESC feature

=== OUTPUT BEGIN ===
ERROR: spaces required around that ':' (ctx:VxW)
#26: FILE: hw/block/virtio-blk.c:937:
+                 s->conf.seg_max_adjust ? s->conf.queue_size: 128);
                                                             ^

total: 1 errors, 0 warnings, 12 lines checked

Commit 166948ef3ae9 (virtio-blk: seg_max do not subtract 2 if host has 
VIRTIO_RING_F_INDIRECT_DESC feature) has style problems, please review.  If any 
of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20201119085437.5333-1-RockCui-oc@zhaoxin.com/testing.checkpatch/?type=message">http://patchew.org/logs/20201119085437.5333-1-RockCui-oc@zhaoxin.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

reply via email to

[Prev in Thread] Current Thread [Next in Thread]