Re: [PATCH 1/7] Introduce 'track-writes-ram' migration capability.

[Andrey Gruzdev]

On 18.11.2020 17:31, Eric Blake wrote:
> On 11/18/20 5:22 AM, Andrey Gruzdev wrote:
> > Signed-off-by: Andrey Gruzdev <andrey.gruzdev@virtuozzo.com>
> > ---
> >   migration/migration.c | 96 +++++++++++++++++++++++++++++++++++++++++++
> >   migration/migration.h |  1 +
> >   qapi/migration.json   |  7 +++-
> >   3 files changed, 103 insertions(+), 1 deletion(-)
>
> Reviewing just the UI:
>
> > +++ b/qapi/migration.json
> > @@ -442,6 +442,11 @@
> >   # @validate-uuid: Send the UUID of the source to allow the destination
> >   #                 to ensure it is the same. (since 4.2)
> >   #
> > +# @track-writes-ram: If enabled, the migration stream will be a snapshot
> > +#                    of the VM exactly at the point when the migration
> > +#                    procedure starts. The VM RAM is saved with running VM.
> > +#                    (since 5.2)
>
> This is a new feature, so it is too late for 5.2; this will need to be 6.0.

Yes, agree.

> > +#
> >   # Since: 1.2
> >   ##
> >   { 'enum': 'MigrationCapability',
> > @@ -449,7 +454,7 @@
> >              'compress', 'events', 'postcopy-ram', 'x-colo', 'release-ram',
> >              'block', 'return-path', 'pause-before-switchover', 'multifd',
> >              'dirty-bitmaps', 'postcopy-blocktime', 'late-block-activate',
> > -           'x-ignore-shared', 'validate-uuid' ] }
> > +           'x-ignore-shared', 'validate-uuid', 'track-writes-ram'] }
> >   
> >   ##
> >   # @MigrationCapabilityStatus:

--
Andrey Gruzdev, Principal Engineer
Virtuozzo GmbH  +7-903-247-6397
                virtuzzo.com