Re: Regressions in build process introduced since August

[Stefan Weil]

Am 18.11.20 um 16:34 schrieb Daniel P. Berrangé:

> On Sun, Nov 15, 2020 at 11:57:25AM +0100, Stefan Weil wrote:
> > *** Setting INSTALLER no longer handled
> >
> > meson.build sets a hard name for the Windows installer executable: installer
> > = 'qemu-setup-' + meson.project_version() + '.exe'.
> >
> > Previously the installer name could be changed by running `make installer
> > INSTALLER=qemu-setup-something.exe`. This no longer works. Is there an
> > alternative solution how the name of the installer executable can be set? Or
> > how could I reimplement the lost functionality?
> Why were you needing to override the name ?  Was this so that you can
> give distinct names to the Win32 vs Win64 installer exes ?
>
> If so, would it be better if QEMU used a distinct filename for the
> Win32 vs Win64 installers automatically, to avoid need to override
> at all ?


I now use installer names like qemu-w64-setup-20201118.exe since about 6 
years, so yes, my names include w32 or w64 to show whether they contain 
32 or 64 bit binaries, and they also contain a date instead of the QEMU 
version.

For my build process I now create the default name and rename it later. 
That solves the problem for me.

Stefan