[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH-for-5.2? 1/2] tests/qtest: variable defined by g_autofree nee
From: |
Havard Skinnemoen |
Subject: |
Re: [PATCH-for-5.2? 1/2] tests/qtest: variable defined by g_autofree need to be initialized |
Date: |
Wed, 18 Nov 2020 09:12:25 -0800 |
On Wed, Nov 18, 2020 at 3:57 AM Chen Qun <kuhn.chenqun@huawei.com> wrote:
>
> According to the glib function requirements, we need initialise
> the variable. Otherwise there will be compilation warnings:
>
> glib-autocleanups.h:28:3: warning: ‘full_name’ may be
> used uninitialized in this function [-Wmaybe-uninitialized]
> 28 | g_free (*pp);
> | ^~~~~~~~~~~~
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: Havard Skinnemoen <hskinnemoen@google.com>
I'd be totally fine with Philippe's suggestion too.
Thanks!
> ---
> tests/qtest/npcm7xx_timer-test.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/tests/qtest/npcm7xx_timer-test.c
> b/tests/qtest/npcm7xx_timer-test.c
> index f08b0cd62a..83774a5b90 100644
> --- a/tests/qtest/npcm7xx_timer-test.c
> +++ b/tests/qtest/npcm7xx_timer-test.c
> @@ -512,11 +512,9 @@ static void test_disable_on_expiration(gconstpointer
> test_data)
> */
> static void tim_add_test(const char *name, const TestData *td, GTestDataFunc
> fn)
> {
> - g_autofree char *full_name;
> -
> - full_name = g_strdup_printf("npcm7xx_timer/tim[%d]/timer[%d]/%s",
> - tim_index(td->tim), timer_index(td->timer),
> - name);
> + g_autofree char *full_name = g_strdup_printf(
> + "npcm7xx_timer/tim[%d]/timer[%d]/%s", tim_index(td->tim),
> + timer_index(td->timer), name);
> qtest_add_data_func(full_name, td, fn);
> }
>
> --
> 2.23.0
>
[PATCH-for-5.2? 2/2] tests/qtest: fix memleak in npcm7xx_watchdog_timer-test, Chen Qun, 2020/11/18