[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v9 08/12] hw/block/nvme: Support Zoned Namespace Command Set
From: |
Keith Busch |
Subject: |
Re: [PATCH v9 08/12] hw/block/nvme: Support Zoned Namespace Command Set |
Date: |
Tue, 17 Nov 2020 16:32:34 -0800 |
On Thu, Nov 12, 2020 at 08:36:39PM +0100, Klaus Jensen wrote:
> On Nov 5 11:53, Dmitry Fomichev wrote:
> > @@ -133,6 +300,12 @@ static Property nvme_ns_props[] = {
> > DEFINE_BLOCK_PROPERTIES(NvmeNamespace, blkconf),
> > DEFINE_PROP_UINT32("nsid", NvmeNamespace, params.nsid, 0),
> > DEFINE_PROP_UUID("uuid", NvmeNamespace, params.uuid),
> > + DEFINE_PROP_BOOL("zoned", NvmeNamespace, params.zoned, false),
>
> I disagree on this. Using the "magic" value ensures that only one
> command set can be selected. We can do a custom property so we can set
> `iocs=zoned` as well as `iocs=0x2` if that makes it more user friendly?
IMO, 'iocs' is a rather difficult parameter name for a user to remember
compared to 'zoned=true'. While 'iocs' is a spec field, the spec isn't
very user friendly either, and these user parameters can hide the spec
terms behind human comprehensible names.
- [PATCH v9 03/12] hw/block/nvme: Separate read and write handlers, (continued)
- [PATCH v9 03/12] hw/block/nvme: Separate read and write handlers, Dmitry Fomichev, 2020/11/04
- [PATCH v9 04/12] hw/block/nvme: Merge nvme_write_zeroes() with nvme_write(), Dmitry Fomichev, 2020/11/04
- [PATCH v9 05/12] hw/block/nvme: Add support for Namespace Types, Dmitry Fomichev, 2020/11/04
- [PATCH v9 06/12] hw/block/nvme: Support allocated CNS command variants, Dmitry Fomichev, 2020/11/04
- [PATCH v9 07/12] block/nvme: Make ZNS-related definitions, Dmitry Fomichev, 2020/11/04
- [PATCH v9 09/12] hw/block/nvme: Introduce max active and open zone limits, Dmitry Fomichev, 2020/11/04
- [PATCH v9 08/12] hw/block/nvme: Support Zoned Namespace Command Set, Dmitry Fomichev, 2020/11/04
- [PATCH v9 10/12] hw/block/nvme: Support Zone Descriptor Extensions, Dmitry Fomichev, 2020/11/04
- [PATCH v9 11/12] hw/block/nvme: Add injection of Offline/Read-Only zones, Dmitry Fomichev, 2020/11/04
- [PATCH v9 12/12] hw/block/nvme: Document zoned parameters in usage text, Dmitry Fomichev, 2020/11/04