[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-5.2? 1/2] authz-pam: Check that 'service' property is set
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH for-5.2? 1/2] authz-pam: Check that 'service' property is set |
|
Date: |
Tue, 17 Nov 2020 19:00:15 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 |
On 11/17/20 5:30 PM, Kevin Wolf wrote:
> If the 'service' property is not set, we'll call pam_start() with a NULL
> pointer for the service name. This fails and leaves a message like this
> in the syslog:
>
> qemu-storage-daemon[294015]: PAM pam_start: invalid argument: service == NULL
>
> Make specifying the property mandatory and catch the error already
> during the creation of the object.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> authz/pamacct.c | 6 ++++++
> 1 file changed, 6 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>