[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 3/9] hw/input/ps2.c: Remove remnants of printf debug
From: |
Peter Maydell |
Subject: |
[PULL 3/9] hw/input/ps2.c: Remove remnants of printf debug |
Date: |
Tue, 17 Nov 2020 13:48:28 +0000 |
In commit 5edab03d4040 we added tracepoints to the ps2 keyboard
and mouse emulation. However we didn't remove all the debug-by-printf
support. In fact there is only one printf() remaining, and it is
redundant with the trace_ps2_write_mouse() event next to it.
Remove the printf() and the now-unused DEBUG* macros.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Message-id: 20201101133258.4240-1-peter.maydell@linaro.org
---
hw/input/ps2.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/hw/input/ps2.c b/hw/input/ps2.c
index f8746d2f52c..72cdb80ae1c 100644
--- a/hw/input/ps2.c
+++ b/hw/input/ps2.c
@@ -33,12 +33,6 @@
#include "trace.h"
-/* debug PC keyboard */
-//#define DEBUG_KBD
-
-/* debug PC keyboard : only mouse */
-//#define DEBUG_MOUSE
-
/* Keyboard Commands */
#define KBD_CMD_SET_LEDS 0xED /* Set keyboard leds */
#define KBD_CMD_ECHO 0xEE
@@ -790,9 +784,6 @@ void ps2_write_mouse(void *opaque, int val)
PS2MouseState *s = (PS2MouseState *)opaque;
trace_ps2_write_mouse(opaque, val);
-#ifdef DEBUG_MOUSE
- printf("kbd: write mouse 0x%02x\n", val);
-#endif
switch(s->common.write_cmd) {
default:
case -1:
--
2.20.1
- [PULL 0/9] target-arm queue, Peter Maydell, 2020/11/17
- [PULL 1/9] hw/arm/virt: ARM_VIRT must select ARM_GIC, Peter Maydell, 2020/11/17
- [PULL 2/9] exynos: Fix bad printf format specifiers, Peter Maydell, 2020/11/17
- [PULL 5/9] register: Remove unnecessary NULL check, Peter Maydell, 2020/11/17
- [PULL 4/9] target/openrisc: Remove dead code attempting to check "is timer disabled", Peter Maydell, 2020/11/17
- [PULL 3/9] hw/input/ps2.c: Remove remnants of printf debug,
Peter Maydell <=
- [PULL 6/9] util/cutils: Fix Coverity array overrun in freq_to_str(), Peter Maydell, 2020/11/17
- [PULL 8/9] hw/misc/tmp105: reset the T_low and T_High registers, Peter Maydell, 2020/11/17
- [PULL 9/9] tmp105: Correct handling of temperature limit checks, Peter Maydell, 2020/11/17
- [PULL 7/9] configure: Make "does libgio work" test pull in some actual functions, Peter Maydell, 2020/11/17
- Re: [PULL 0/9] target-arm queue, no-reply, 2020/11/17
- Re: [PULL 0/9] target-arm queue, Peter Maydell, 2020/11/17