[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman
From: |
Peter Maydell |
Subject: |
Re: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category |
Date: |
Tue, 17 Nov 2020 11:08:48 +0000 |
On Tue, 17 Nov 2020 at 05:41, Markus Armbruster <armbru@redhat.com> wrote:
>
> Peter Maydell <peter.maydell@linaro.org> writes:
> > I'm really dubious of devices that directly inherit from
> > TYPE_DEVICE, because their reset method won't be automatically
> > called. In this case it looks like the TYPE_BCM2835_CPRMAN
> > device's reset method manually calls reset on these devices,
> > though, so it isn't actually buggy, just confusing.
>
> I guess this is a trap for unwary implementers, aggravated by our usual
> dearth of qdev documentation. I can see ~100 .parent = TYPE_DEVICE
> lines. Checking them all manually won't be fun. Any automation ideas?
>
> The concept "bus-less device" is sane. We used not to have it, and the
> resulting need for pseudo-busses was annoying enough to make us add
> bus-less devices.
Yeah, the problem really is that our reset handling remains a
mess. I'm not sure (a) what the right model for reset is and
(b) what would be a feasible transition plan to get from
here to there...
thanks
-- PMM
- [PATCH 11/13] spitz: put some Spitz-family devices into the correct category, (continued)
- [PATCH 11/13] spitz: put some Spitz-family devices into the correct category, Gan Qixin, 2020/11/16
- [PATCH 10/13] tosa-ssp: put it into the 'misc' category, Gan Qixin, 2020/11/16
- [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category, Gan Qixin, 2020/11/16
- Re: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category, Philippe Mathieu-Daudé, 2020/11/16
- Re: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category, Thomas Huth, 2020/11/16
- Re: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category, Markus Armbruster, 2020/11/16
- Re: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category, Peter Maydell, 2020/11/16
- Re: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category, Markus Armbruster, 2020/11/17
- Re: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category,
Peter Maydell <=
- Re: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category, Thomas Huth, 2020/11/17
- Re: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category, Markus Armbruster, 2020/11/18
- Should bus-less devices default to .user_creatable = false? (was: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category), Markus Armbruster, 2020/11/18
- Re: Should bus-less devices default to .user_creatable = false? (was: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category), Thomas Huth, 2020/11/18
- RE: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category, ganqixin, 2020/11/17