Re: [PATCH 7/7] scsi: move host_status handling into SCSI drivers

[Paolo Bonzini]

On 17/11/20 07:55, Hannes Reinecke wrote:
> On 11/16/20 11:00 PM, Paolo Bonzini wrote:
> > On 16/11/20 20:05, Hannes Reinecke wrote:
> > > > > +    if (sreq->host_status == SCSI_HOST_OK) {
> > > > > +        SCSISense sense;
> > > > > +
> > > > > +        sreq->status = 
> > > > > scsi_sense_from_host_status(sreq->host_status, &sense);
> > > > > +        if (sreq->status == CHECK_CONDITION) {
> > > > > +            scsi_req_build_sense(sreq, sense);
> > > > > +        }
> > > > > +    }
> > > >
> > > > Should be != of course.
> > > No.
> > > scsi_req_build_sense() transfers the sense code from the second argument
> > > into a proper SCSI sense. Which is only set if the status is 
> > > CHECK_CONDITION...
> >
> > I mean sreq->host_status != SCSI_HOST_OK.  I might be wrong, but every 
> > other HBA is using that...
> Bah. Yes, of course, you are right.
>
> Shall I resubmit? Or how is the process nowadays?

Depends on how busy and grumpy I am. :)  Since we're right in the middle 
of the freeze, let me send a RFC patch for Linux to clean up DID_* a 
little bit.

Paolo