[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 11/17] vhost-user-blk-test: drop unused return value
From: |
Michael S. Tsirkin |
Subject: |
[PULL 11/17] vhost-user-blk-test: drop unused return value |
Date: |
Sun, 15 Nov 2020 17:27:39 -0500 |
From: Stefan Hajnoczi <stefanha@redhat.com>
The sock_path return value was unused and bogus (it doesn't make sense
when there are multiple drives because only the last path is arbitrarily
returned).
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20201111124331.1393747-7-stefanha@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
tests/qtest/vhost-user-blk-test.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/tests/qtest/vhost-user-blk-test.c
b/tests/qtest/vhost-user-blk-test.c
index 4019a72ac0..c5ff610d7a 100644
--- a/tests/qtest/vhost-user-blk-test.c
+++ b/tests/qtest/vhost-user-blk-test.c
@@ -705,8 +705,8 @@ static void quit_storage_daemon(void *qmp_test_state)
g_free(qmp_test_state);
}
-static char *start_vhost_user_blk(GString *cmd_line, int vus_instances,
- int num_queues)
+static void start_vhost_user_blk(GString *cmd_line, int vus_instances,
+ int num_queues)
{
const char *vhost_user_blk_bin = qtest_qemu_storage_daemon_binary();
int fd, qmp_fd, i;
@@ -772,7 +772,6 @@ static char *start_vhost_user_blk(GString *cmd_line, int
vus_instances,
g_test_queue_destroy(quit_storage_daemon, qmp_test_state);
qobject_unref(qtest_qmp(qmp_test_state, "{'execute':
'qmp_capabilities'}"));
- return sock_path;
}
static void *vhost_user_blk_test_setup(GString *cmd_line, void *arg)
--
MST
- [PULL 02/17] meson: move vhost_user_blk_server to meson.build, (continued)
- [PULL 07/17] tests/qtest: add multi-queue test case to vhost-user-blk-test, Michael S. Tsirkin, 2020/11/15
- [PULL 08/17] libqtest: add qtest_socket_server(), Michael S. Tsirkin, 2020/11/15
- [PULL 06/17] test: new qTest case to test the vhost-user-blk-server, Michael S. Tsirkin, 2020/11/15
- [PULL 09/17] vhost-user-blk-test: rename destroy_drive() to destroy_file(), Michael S. Tsirkin, 2020/11/15
- [PULL 11/17] vhost-user-blk-test: drop unused return value,
Michael S. Tsirkin <=
- [PULL 12/17] vhost-user-blk-test: fix races by using fd passing, Michael S. Tsirkin, 2020/11/15
- [PULL 13/17] block/export: port virtio-blk discard/write zeroes input validation, Michael S. Tsirkin, 2020/11/15
- [PULL 14/17] vhost-user-blk-test: test discard/write zeroes invalid inputs, Michael S. Tsirkin, 2020/11/15
- [PULL 15/17] block/export: port virtio-blk read/write range check, Michael S. Tsirkin, 2020/11/15
- [PULL 16/17] contrib/libvhost-user: Fix bad printf format specifiers, Michael S. Tsirkin, 2020/11/15
- [PULL 04/17] configure: mark vhost-user Linux-only, Michael S. Tsirkin, 2020/11/15
- [PULL 10/17] vhost-user-blk-test: close fork child file descriptors, Michael S. Tsirkin, 2020/11/15
- [PULL 17/17] vhost-user-blk/scsi: Fix broken error handling for socket call, Michael S. Tsirkin, 2020/11/15
- Re: [PULL 00/17] pc,vhost: fixes, new test, Peter Maydell, 2020/11/16