[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v10 1/8] Introduce yank feature
From: |
Lukas Straub |
Subject: |
Re: [PATCH v10 1/8] Introduce yank feature |
Date: |
Sun, 15 Nov 2020 09:28:55 +0100 |
On Mon, 02 Nov 2020 07:32:55 +0100
Markus Armbruster <armbru@redhat.com> wrote:
> Lukas Straub <lukasstraub2@web.de> writes:
>
> > The yank feature allows to recover from hanging qemu by "yanking"
> > at various parts. Other qemu systems can register themselves and
> > multiple yank functions. Then all yank functions for selected
> > instances can be called by the 'yank' out-of-band qmp command.
> > Available instances can be queried by a 'query-yank' oob command.
> >
> > Signed-off-by: Lukas Straub <lukasstraub2@web.de>
> > Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
> [...]
> > qapi_storage_daemon_modules = [
> > diff --git a/qapi/qapi-schema.json b/qapi/qapi-schema.json
> > index 0b444b76d2..79c1705ed7 100644
> > --- a/qapi/qapi-schema.json
> > +++ b/qapi/qapi-schema.json
> > @@ -91,3 +91,4 @@
> > { 'include': 'audio.json' }
> > { 'include': 'acpi.json' }
> > { 'include': 'pci.json' }
> > +{ 'include': 'yank.json' }
>
> This adds the documentation at the very end of the reference manual. Is
> this where you want it to go? Check generated
> docs/interop/qemu-qmp-ref.html.
I've moved it above misc for the next version.
> > diff --git a/qapi/yank.json b/qapi/yank.json
> > new file mode 100644
> > index 0000000000..1964a2202e
> > --- /dev/null
> > +++ b/qapi/yank.json
> > @@ -0,0 +1,115 @@
> > +# -*- Mode: Python -*-
> > +# vim: filetype=python
> > +#
> > +
>
> Please add a suitable heading here. Headings look like this:
>
> ##
> # Text of heading goes here
> ##
Changed for the next version.
> Without it, the yank stuff gets squashed into the previous section
> (happens to be PCI).
>
> If you want to add an introduction or overview, it goes right below the
> heading. I'm not asking you to do that, I'm only telling you what's
> possible.
>
> [...]
>
> Solid work, pleasant to review, thanks!
>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>
Thanks!
--
pgpwBpYC2KBbY.pgp
Description: OpenPGP digital signature