[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 21/53] qdev: Add name argument to PropertyInfo.create method
From: |
Eduardo Habkost |
Subject: |
[PATCH v3 21/53] qdev: Add name argument to PropertyInfo.create method |
Date: |
Thu, 12 Nov 2020 16:43:18 -0500 |
This will make it easier to remove the Property.name field in the
future.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
This is a new patch added in series v2
---
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org
---
include/hw/qdev-properties.h | 2 +-
hw/core/qdev-properties.c | 7 ++++---
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h
index 476737b9da..ab9c538ba4 100644
--- a/include/hw/qdev-properties.h
+++ b/include/hw/qdev-properties.h
@@ -34,7 +34,7 @@ struct PropertyInfo {
const QEnumLookup *enum_table;
int (*print)(Object *obj, Property *prop, char *dest, size_t len);
void (*set_default_value)(ObjectProperty *op, const Property *prop);
- void (*create)(ObjectClass *oc, Property *prop);
+ void (*create)(ObjectClass *oc, const char *name, Property *prop);
ObjectPropertyAccessor *get;
ObjectPropertyAccessor *set;
ObjectPropertyRelease *release;
diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c
index 457c7fe4ba..c68a20695d 100644
--- a/hw/core/qdev-properties.c
+++ b/hw/core/qdev-properties.c
@@ -851,9 +851,10 @@ const PropertyInfo qdev_prop_size = {
/* --- object link property --- */
-static void create_link_property(ObjectClass *oc, Property *prop)
+static void create_link_property(ObjectClass *oc, const char *name,
+ Property *prop)
{
- object_class_property_add_link(oc, prop->name, prop->link_type,
+ object_class_property_add_link(oc, name, prop->link_type,
prop->offset,
qdev_prop_allow_set_link_before_realize,
OBJ_PROP_LINK_STRONG);
@@ -893,7 +894,7 @@ static void qdev_class_add_property(DeviceClass *klass,
const char *name,
ObjectClass *oc = OBJECT_CLASS(klass);
if (prop->info->create) {
- prop->info->create(oc, prop);
+ prop->info->create(oc, name, prop);
} else {
ObjectProperty *op;
--
2.28.0
- [PATCH v3 12/53] qdev: Make error_set_from_qdev_prop_error() get Object* argument, (continued)
- [PATCH v3 12/53] qdev: Make error_set_from_qdev_prop_error() get Object* argument, Eduardo Habkost, 2020/11/12
- [PATCH v3 13/53] qdev: Make qdev_propinfo_get_uint16() static, Eduardo Habkost, 2020/11/12
- [PATCH v3 14/53] qdev: Move UUID property to qdev-properties-system.c, Eduardo Habkost, 2020/11/12
- [PATCH v3 17/53] sparc: Use DEFINE_PROP for nwindows property, Eduardo Habkost, 2020/11/12
- [PATCH v3 16/53] qdev: Reuse DEFINE_PROP in all DEFINE_PROP_* macros, Eduardo Habkost, 2020/11/12
- [PATCH v3 15/53] qdev: Move softmmu properties to qdev-properties-system.h, Eduardo Habkost, 2020/11/12
- [PATCH v3 18/53] qdev: Get just property name at error_set_from_qdev_prop_error(), Eduardo Habkost, 2020/11/12
- [PATCH v3 19/53] qdev: Avoid using prop->name unnecessarily, Eduardo Habkost, 2020/11/12
- [PATCH v3 20/53] qdev: Add name parameter to qdev_class_add_property(), Eduardo Habkost, 2020/11/12
- [PATCH v3 21/53] qdev: Add name argument to PropertyInfo.create method,
Eduardo Habkost <=
- [PATCH v3 22/53] qdev: Wrap getters and setters in separate helpers, Eduardo Habkost, 2020/11/12
- [PATCH v3 23/53] qdev: Move dev->realized check to qdev_property_set(), Eduardo Habkost, 2020/11/12
- [PATCH v3 24/53] qdev: Make PropertyInfo.create return ObjectProperty*, Eduardo Habkost, 2020/11/12
- [PATCH v3 25/53] qdev: Make qdev_class_add_property() more flexible, Eduardo Habkost, 2020/11/12
- [PATCH v3 26/53] qdev: Separate generic and device-specific property registration, Eduardo Habkost, 2020/11/12
- [PATCH v3 27/53] qdev: Rename qdev_propinfo_* to field_prop_*, Eduardo Habkost, 2020/11/12
- [PATCH v3 28/53] qdev: Move qdev_prop_tpm declaration to tpm_prop.h, Eduardo Habkost, 2020/11/12
- [PATCH v3 29/53] qdev: Rename qdev_prop_* to prop_info_*, Eduardo Habkost, 2020/11/12
- [PATCH v3 30/53] qdev: Rename qdev_get_prop_ptr() to object_field_prop_ptr(), Eduardo Habkost, 2020/11/12
- [PATCH v3 31/53] qdev: Avoid unnecessary DeviceState* variable at set_prop_arraylen(), Eduardo Habkost, 2020/11/12