Re: [PATCH v5 0/7] iOS and Apple Silicon host support

[Stefan Hajnoczi]

On Sun, Nov 08, 2020 at 03:24:17PM -0800, Joelle van Dyne wrote:
> Based-on: 20201106032921.600200-1-richard.henderson@linaro.org
> ([PATCH v3 00/41] Mirror map JIT memory for TCG)
> 
> These set of changes brings QEMU TCG to iOS devices and future Apple Silicon
> devices. They were originally developed last year and have been working in the
> UTM app. Recently, we ported the changes to master, re-wrote a lot of the 
> build
> script changes for meson, and broke up the patches into more distinct units.
> 
> A summary of the changes:
> 
> * `CONFIG_IOS` defined when building for iOS and iOS specific changes (as well
>   as unsupported code) are gated behind it.
> * A new dependency, libucontext is added since iOS does not have native 
> ucontext
>   and broken support for sigaltstack. libucontext is available as a new option
>   for coroutine backend.
> * For (recent) jailbroken iOS devices as well as upcoming Apple Silicon 
> devices,
>   there are new rules for applications supporting JIT (with the proper
>   entitlement). These rules are implemented as well.
> 
> Since v5:
> 
> * Fixed some more instances of QAPI define of CONFIG_HOST_BLOCK_DEVICE
> * Fixed libucontext build on newer version of GCC

I have pinged Software Freedom Conservancy about an opinion regarding
merging the reverse-engineered part. Hope to get a reply soon. You are
on CC so you'll see it.

QEMU is currently in freeze (fixes only, no new features) for the
upcoming 5.2 release. The development tree will open again at the start
of December:
https://wiki.qemu.org/Planning/5.2

The code looks good to me. Thank you!

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

signature.asc
Description: PGP signature