[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH-for-5.2 v2] hw/i386/acpi-build: Fix maybe-uninitialized error
|
From: |
Michael S. Tsirkin |
|
Subject: |
Re: [PATCH-for-5.2 v2] hw/i386/acpi-build: Fix maybe-uninitialized error when ACPI hotplug off |
|
Date: |
Thu, 12 Nov 2020 04:02:44 -0500 |
On Thu, Nov 12, 2020 at 09:21:47AM +0530, Ani Sinha wrote:
>
>
> On Sun, Nov 8, 2020 at 22:40 Philippe Mathieu-Daudé <philmd@redhat.com>
> wrote:
>
> On 11/8/20 4:58 AM, Ani Sinha wrote:
> > On Sun, Nov 8, 2020 at 1:10 AM Philippe Mathieu-Daudé
> <philmd@redhat.com>
> wrote:
> >>
> >> GCC 9.3.0 thinks that 'method' can be left uninitialized. This code
> >> is already in the "if (bsel || pcihp_bridge_en)" block statement,
> >> but it isn't smart enough to figure it out.
> >>
> >> Restrict the code to be used only in the "if (bsel || pcihp_bridge_en)"
> >> block statement to fix (on Ubuntu):
> >>
> >>Â Â ../hw/i386/acpi-build.c: In function
> 'build_append_pci_bus_devices':
> >>Â Â ../hw/i386/acpi-build.c:496:9: error: 'method' may be used
> uninitialized
> >>Â Â in this function [-Werror=maybe-uninitialized]
> >>Â Â Â 496 |Â Â Â Â Â aml_append(parent_scope, method);
> >>Â Â Â Â Â |Â Â Â Â Â ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >>Â Â cc1: all warnings being treated as errors
> >
> > OK I looked at the patch closely and it makes sense. Can you please
> > run a "make check" to make sure we have not broken anything?
>
> Yes I did...
>
>
> Has this been queued Michael?
tagged, thanks!
>
>
>
>