Re: [PATCH v3 15/41] accel/tcg: Support split-wx for linux with memfd

[Richard Henderson]

On 11/10/20 9:03 AM, Alex Bennée wrote:
> 
> Richard Henderson <richard.henderson@linaro.org> writes:
> 
>> We cannot use a real temp file, because we would need to find
>> a filesystem that does not have noexec enabled.  However, a
>> memfd is not associated with any filesystem.
>>
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> 
> It looks like this breaks --enable-tcg-interpreter:
> 
>   FAILED: libqemu-ppc64-softmmu.fa.p/accel_tcg_translate-all.c.o
>   cc -Ilibqemu-ppc64-softmmu.fa.p -I. -I../.. -Itarget/ppc -I../../target/ppc 
> -I../../dtc/libfdt -I../../capstone/include/capstone -Iqapi -Itrace -Iui 
> -Iui/shader -I/usr/include/spice-server -I/usr/include/spice-1 
> -I/usr/include/pixman-1 -I/usr/include/libdrm -I/usr/include/glib-2.0 
> -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -fdiagnostics-color=auto -pipe 
> -Wall -Winvalid-pch -Werror -std=gnu99 -O2 -g -U_FORTIFY_SOURCE 
> -D_FORTIFY_SOURCE=2 -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 
> -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wundef 
> -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv 
> -Wold-style-declaration -Wold-style-definition -Wtype-limits 
> -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wempty-body 
> -Wnested-externs -Wendif-labels -Wexpansion-to-defined 
> -Wno-missing-include-dirs -Wno-shift-negative-value -Wno-psabi 
> -fstack-protector-strong -DLEGACY_RDMA_REG_MR -isystem 
> /home/alex/lsrc/qemu.git/linux-headers -isystem linux-headers -iquote 
> /home/alex/lsrc/qemu.git/tcg/tci -iquote . -iquote /home/alex/lsrc/qemu.git 
> -iquote /home/alex/lsrc/qemu.git/accel/tcg -iquote 
> /home/alex/lsrc/qemu.git/include -iquote 
> /home/alex/lsrc/qemu.git/disas/libvixl -pthread -fPIC 
> -isystem../../linux-headers -isystemlinux-headers -DNEED_CPU_H 
> '-DCONFIG_TARGET="ppc64-softmmu-config-target.h"' 
> '-DCONFIG_DEVICES="ppc64-softmmu-config-devices.h"' -MD -MQ 
> libqemu-ppc64-softmmu.fa.p/accel_tcg_translate-all.c.o -MF 
> libqemu-ppc64-softmmu.fa.p/accel_tcg_translate-all.c.o.d -o 
> libqemu-ppc64-softmmu.fa.p/accel_tcg_translate-all.c.o -c 
> ../../accel/tcg/translate-all.c
>   ../../accel/tcg/translate-all.c:1138:13: error: 
> ‘alloc_code_gen_buffer_splitwx_memfd’ defined but not used 
> [-Werror=unused-function]
>    static bool alloc_code_gen_buffer_splitwx_memfd(size_t size, Error **errp)
>                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>   cc1: all warnings being treated as errors

Bah, this will actually be patch 39, where I switch from if to ifdef.  I'll
have to rearrange those.


r~