[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: QOM address space handling

From: Paolo Bonzini
Subject: Re: QOM address space handling
Date: Tue, 10 Nov 2020 16:08:16 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0

On 10/11/20 16:03, Eduardo Habkost wrote:
Does anyone have any arguments for which solution is preferred?
I'd say (2) is preferred, as we don't expect object_new(T) to
have any side effects outside the object instance state.

Since there are no listeners, the side effects of address_space_init() are relatively limited. So doing it in instance_init is not a big deal.

address_space_init() calls in the code today seem to be in
realize functions.

However, I wonder if we could make this simpler (and mistakes
less fatal) if we make AddressSpace a QOM child of the device.
Paolo, would it be too much overhead to make AddressSpace a QOM

No, it wouldn't.  AddressSpace is already quite heavyweight.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]