[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 5/6] physmem: improve ram size error messages
From: |
Paolo Bonzini |
Subject: |
[PULL 5/6] physmem: improve ram size error messages |
Date: |
Tue, 10 Nov 2020 06:29:08 -0500 |
From: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
Ram size mismatch condition logs below message.
"Length mismatch: pc.ram: 0x80000000 in != 0x180000000: Invalid argument"
This patch improves the readability of error messages.
Removed the superflous "in" and changed "Length" to "Size".
Signed-off-by: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
Reported-by: Li Zhang <li.zhang@cloud.ionos.com>
Message-Id: <20201022111302.8105-1-pankaj.gupta.linux@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
softmmu/physmem.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/softmmu/physmem.c b/softmmu/physmem.c
index 0b31be2928..dd60ff79e9 100644
--- a/softmmu/physmem.c
+++ b/softmmu/physmem.c
@@ -1756,15 +1756,15 @@ int qemu_ram_resize(RAMBlock *block, ram_addr_t
newsize, Error **errp)
if (!(block->flags & RAM_RESIZEABLE)) {
error_setg_errno(errp, EINVAL,
- "Length mismatch: %s: 0x" RAM_ADDR_FMT
- " in != 0x" RAM_ADDR_FMT, block->idstr,
+ "Size mismatch: %s: 0x" RAM_ADDR_FMT
+ " != 0x" RAM_ADDR_FMT, block->idstr,
newsize, block->used_length);
return -EINVAL;
}
if (block->max_length < newsize) {
error_setg_errno(errp, EINVAL,
- "Length too large: %s: 0x" RAM_ADDR_FMT
+ "Size too large: %s: 0x" RAM_ADDR_FMT
" > 0x" RAM_ADDR_FMT, block->idstr,
newsize, block->max_length);
return -EINVAL;
--
2.26.2
- [PULL 0/6] Misc fixes for QEMU 5.2-rc2, Paolo Bonzini, 2020/11/10
- [PULL 1/6] meson: Clarify the confusing vhost-user vs. vhost-kernel output, Paolo Bonzini, 2020/11/10
- [PULL 6/6] pvpanic: Advertise the PVPANIC_CRASHLOADED event support, Paolo Bonzini, 2020/11/10
- [PULL 2/6] fix make clean/distclean, Paolo Bonzini, 2020/11/10
- [PULL 5/6] physmem: improve ram size error messages,
Paolo Bonzini <=
- [PULL 4/6] Makefile: No echoing for 'make help V=1', Paolo Bonzini, 2020/11/10
- [PULL 3/6] replay: remove some dead code, Paolo Bonzini, 2020/11/10
- Re: [PULL 0/6] Misc fixes for QEMU 5.2-rc2, no-reply, 2020/11/10
- Re: [PULL 0/6] Misc fixes for QEMU 5.2-rc2, Peter Maydell, 2020/11/10