[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 1/4] block/accounting.c: Use lock guard macros
From: |
Gan Qixin |
Subject: |
[PATCH 1/4] block/accounting.c: Use lock guard macros |
Date: |
Mon, 9 Nov 2020 23:43:24 +0800 |
Replace manual lock()/unlock() calls with lock guard macros
(QEMU_LOCK_GUARD/WITH_QEMU_LOCK_GUARD) in block/accounting.c.
Signed-off-by: Gan Qixin <ganqixin@huawei.com>
---
block/accounting.c | 32 +++++++++++++++-----------------
1 file changed, 15 insertions(+), 17 deletions(-)
diff --git a/block/accounting.c b/block/accounting.c
index 8d41c8a83a..2030851d79 100644
--- a/block/accounting.c
+++ b/block/accounting.c
@@ -199,29 +199,27 @@ static void block_account_one_io(BlockAcctStats *stats,
BlockAcctCookie *cookie,
return;
}
- qemu_mutex_lock(&stats->lock);
-
- if (failed) {
- stats->failed_ops[cookie->type]++;
- } else {
- stats->nr_bytes[cookie->type] += cookie->bytes;
- stats->nr_ops[cookie->type]++;
- }
+ WITH_QEMU_LOCK_GUARD(&stats->lock) {
+ if (failed) {
+ stats->failed_ops[cookie->type]++;
+ } else {
+ stats->nr_bytes[cookie->type] += cookie->bytes;
+ stats->nr_ops[cookie->type]++;
+ }
- block_latency_histogram_account(&stats->latency_histogram[cookie->type],
- latency_ns);
+
block_latency_histogram_account(&stats->latency_histogram[cookie->type],
+ latency_ns);
- if (!failed || stats->account_failed) {
- stats->total_time_ns[cookie->type] += latency_ns;
- stats->last_access_time_ns = time_ns;
+ if (!failed || stats->account_failed) {
+ stats->total_time_ns[cookie->type] += latency_ns;
+ stats->last_access_time_ns = time_ns;
- QSLIST_FOREACH(s, &stats->intervals, entries) {
- timed_average_account(&s->latency[cookie->type], latency_ns);
+ QSLIST_FOREACH(s, &stats->intervals, entries) {
+ timed_average_account(&s->latency[cookie->type], latency_ns);
+ }
}
}
- qemu_mutex_unlock(&stats->lock);
-
cookie->type = BLOCK_ACCT_NONE;
}
--
2.23.0