Re: [RFC v1 00/10] i386 cleanup

qemu-devel
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v1 00/10] i386 cleanup

From:	no-reply
Subject:	Re: [RFC v1 00/10] i386 cleanup
Date:	Mon, 9 Nov 2020 09:45:55 -0800 (PST)
Patchew URL: 20201109172755.16500-1-cfontana@suse.de/">https://patchew.org/QEMU/20201109172755.16500-1-cfontana@suse.de/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20201109172755.16500-1-cfontana@suse.de
Subject: [RFC v1 00/10] i386 cleanup
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20201109090422.2445166-1-f4bug@amsat.org -> 
patchew/20201109090422.2445166-1-f4bug@amsat.org
 - [tag update]      patchew/20201109162621.18885-1-peter.maydell@linaro.org -> 
patchew/20201109162621.18885-1-peter.maydell@linaro.org
 * [new tag]         patchew/20201109172755.16500-1-cfontana@suse.de -> 
patchew/20201109172755.16500-1-cfontana@suse.de
Switched to a new branch 'test'
79d85c4 module: add priority to module_init
c947a1f i386: split cpu.c and defer x86 models registration
22999b7 module: introduce MODULE_INIT_ACCEL_CPU
41dd5f6 i386: move TCG cpu class initialization out of helper.c
09b68b7 i386: move cpu dump out of helper.c into cpu-dump.c
dd91165 i386: move TCG accel files into accel/tcg/
c341f6d i386: move hvf accel files into accel/hvf/
76dbf66 i386: move hax accel files to accel/hax/
2c0221e i386: move whpx accel files to accel/whpx/
41d7cb1 i386: move kvm accel files into accel/kvm/

=== OUTPUT BEGIN ===
1/10 Checking commit 41d7cb1d063e (i386: move kvm accel files into accel/kvm/)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#128: 
rename from target/i386/hyperv-proto.h

total: 0 errors, 1 warnings, 150 lines checked

Patch 1/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/10 Checking commit 2c0221e3dcf3 (i386: move whpx accel files to accel/whpx/)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#27: 
new file mode 100644

total: 0 errors, 1 warnings, 32 lines checked

Patch 2/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/10 Checking commit 76dbf6695e74 (i386: move hax accel files to accel/hax/)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#25: 
rename from target/i386/hax-all.c

total: 0 errors, 1 warnings, 47 lines checked

Patch 3/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/10 Checking commit c341f6d31a78 (i386: move hvf accel files into accel/hvf/)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#26: 
rename from target/i386/hvf/README.md

total: 0 errors, 1 warnings, 17 lines checked

Patch 4/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/10 Checking commit dd91165f2ce0 (i386: move TCG accel files into accel/tcg/)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#12: 
rename from target/i386/bpt_helper.c

total: 0 errors, 1 warnings, 39 lines checked

Patch 5/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/10 Checking commit 09b68b7a3ccb (i386: move cpu dump out of helper.c into 
cpu-dump.c)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#11: 
new file mode 100644

ERROR: braces {} are necessary for all arms of this statement
#128: FILE: target/i386/cpu-dump.c:113:
+    if (!(env->hflags & HF_PE_MASK) || !(sc->flags & DESC_P_MASK))
[...]

WARNING: Block comments use a leading /* on a separate line
#172: FILE: target/i386/cpu-dump.c:157:
+/* ARRAY_SIZE check is not required because

WARNING: Block comments use a leading /* on a separate line
#211: FILE: target/i386/cpu-dump.c:196:
+/* ARRAY_SIZE check is not required because

ERROR: line over 90 characters
#373: FILE: target/i386/cpu-dump.c:358:
+        qemu_fprintf(f, "RAX=%016" PRIx64 " RBX=%016" PRIx64 " RCX=%016" 
PRIx64 " RDX=%016" PRIx64 "\n"

ERROR: line over 90 characters
#374: FILE: target/i386/cpu-dump.c:359:
+                     "RSI=%016" PRIx64 " RDI=%016" PRIx64 " RBP=%016" PRIx64 " 
RSP=%016" PRIx64 "\n"

ERROR: line over 90 characters
#375: FILE: target/i386/cpu-dump.c:360:
+                     "R8 =%016" PRIx64 " R9 =%016" PRIx64 " R10=%016" PRIx64 " 
R11=%016" PRIx64 "\n"

ERROR: line over 90 characters
#376: FILE: target/i386/cpu-dump.c:361:
+                     "R12=%016" PRIx64 " R13=%016" PRIx64 " R14=%016" PRIx64 " 
R15=%016" PRIx64 "\n"

ERROR: line over 90 characters
#377: FILE: target/i386/cpu-dump.c:362:
+                     "RIP=%016" PRIx64 " RFL=%08x [%c%c%c%c%c%c%c] CPL=%d 
II=%d A20=%d SMM=%d HLT=%d\n",

ERROR: space required before the open parenthesis '('
#436: FILE: target/i386/cpu-dump.c:421:
+    for(i = 0; i < 6; i++) {

WARNING: line over 80 characters
#448: FILE: target/i386/cpu-dump.c:433:
+        qemu_fprintf(f, "CR0=%08x CR2=%016" PRIx64 " CR3=%016" PRIx64 " 
CR4=%08x\n",

ERROR: space required before the open parenthesis '('
#453: FILE: target/i386/cpu-dump.c:438:
+        for(i = 0; i < 4; i++)

ERROR: braces {} are necessary for all arms of this statement
#453: FILE: target/i386/cpu-dump.c:438:
+        for(i = 0; i < 4; i++)
[...]

ERROR: space required before the open parenthesis '('
#469: FILE: target/i386/cpu-dump.c:454:
+        for(i = 0; i < 4; i++) {

ERROR: braces {} are necessary for all arms of this statement
#476: FILE: target/i386/cpu-dump.c:461:
+        if ((unsigned)env->cc_op < CC_OP_NB)
[...]
+        else
[...]

WARNING: line over 80 characters
#477: FILE: target/i386/cpu-dump.c:462:
+            snprintf(cc_op_name, sizeof(cc_op_name), "%s", 
cc_op_str[env->cc_op]);

ERROR: space required before the open parenthesis '('
#497: FILE: target/i386/cpu-dump.c:482:
+        for(i = 0; i < 8; i++) {

ERROR: spaces required around that '=' (ctx:VxV)
#507: FILE: target/i386/cpu-dump.c:492:
+        for(i=0;i<8;i++) {
              ^

ERROR: space required after that ';' (ctx:VxV)
#507: FILE: target/i386/cpu-dump.c:492:
+        for(i=0;i<8;i++) {
                ^

ERROR: spaces required around that '<' (ctx:VxV)
#507: FILE: target/i386/cpu-dump.c:492:
+        for(i=0;i<8;i++) {
                  ^

ERROR: space required after that ';' (ctx:VxV)
#507: FILE: target/i386/cpu-dump.c:492:
+        for(i=0;i<8;i++) {
                    ^

ERROR: space required before the open parenthesis '('
#507: FILE: target/i386/cpu-dump.c:492:
+        for(i=0;i<8;i++) {

ERROR: braces {} are necessary for all arms of this statement
#512: FILE: target/i386/cpu-dump.c:497:
+            if ((i & 1) == 1)
[...]
+            else
[...]

ERROR: braces {} are necessary for all arms of this statement
#517: FILE: target/i386/cpu-dump.c:502:
+        if (env->hflags & HF_CS64_MASK)
[...]
+        else
[...]

ERROR: spaces required around that '=' (ctx:VxV)
#521: FILE: target/i386/cpu-dump.c:506:
+        for(i=0;i<nb;i++) {
              ^

ERROR: space required after that ';' (ctx:VxV)
#521: FILE: target/i386/cpu-dump.c:506:
+        for(i=0;i<nb;i++) {
                ^

ERROR: spaces required around that '<' (ctx:VxV)
#521: FILE: target/i386/cpu-dump.c:506:
+        for(i=0;i<nb;i++) {
                  ^

ERROR: space required after that ';' (ctx:VxV)
#521: FILE: target/i386/cpu-dump.c:506:
+        for(i=0;i<nb;i++) {
                     ^

ERROR: space required before the open parenthesis '('
#521: FILE: target/i386/cpu-dump.c:506:
+        for(i=0;i<nb;i++) {

ERROR: braces {} are necessary for all arms of this statement
#528: FILE: target/i386/cpu-dump.c:513:
+            if ((i & 1) == 1)
[...]
+            else
[...]

total: 25 errors, 5 warnings, 1078 lines checked

Patch 6/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/10 Checking commit 41dd5f6ce813 (i386: move TCG cpu class initialization out 
of helper.c)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#466: 
new file mode 100644

total: 0 errors, 1 warnings, 610 lines checked

Patch 7/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/10 Checking commit 22999b75bce2 (module: introduce MODULE_INIT_ACCEL_CPU)
9/10 Checking commit c947a1fbb439 (i386: split cpu.c and defer x86 models 
registration)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#90: 
new file mode 100644

WARNING: line over 80 characters
#549: FILE: target/i386/accel/tcg/tcg-cpu-type.c:101:
+    memory_region_add_subregion_overlap(cpu->cpu_as_root, 0, cpu->cpu_as_mem, 
0);

total: 0 errors, 2 warnings, 1501 lines checked

Patch 9/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/10 Checking commit 79d85c44139c (module: add priority to module_init)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20201109172755.16500-1-cfontana@suse.de/testing.checkpatch/?type=message">http://patchew.org/logs/20201109172755.16500-1-cfontana@suse.de/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
[Prev in Thread]
Current Thread
[Next in Thread]
Re: [RFC v1 09/10] i386: split cpu.c and defer x86 models registration, (continued)
- [RFC v1 10/10] module: add priority to module_init, Claudio Fontana, 2020/11/09
- Re: [RFC v1 00/10] i386 cleanup, no-reply <=
Prev by Date: Re: [RFC PATCH v3 10/13] target/arm/cpu: Add cpu cache description for arm
Next by Date: Re: [PULL 00/15] Block patches for 5.2.0-rc1
Previous by thread: [RFC v1 10/10] module: add priority to module_init
Next by thread: [PULL 00/15] Block patches for 5.2.0-rc1
Index(es):
- Date
- Thread