[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] accel: Only include TCG stubs in user-mode only builds
From: |
Claudio Fontana |
Subject: |
Re: [PATCH 1/3] accel: Only include TCG stubs in user-mode only builds |
Date: |
Mon, 9 Nov 2020 10:55:45 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 |
On 11/9/20 10:45 AM, Philippe Mathieu-Daudé wrote:
> We only require TCG stubs in user-mode emulation.
> Do not build stubs restricted to system-mode emulation
> in a user-mode only build.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> accel/meson.build | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/accel/meson.build b/accel/meson.build
> index b26cca227a4..609772f129b 100644
> --- a/accel/meson.build
> +++ b/accel/meson.build
> @@ -1,10 +1,12 @@
> softmmu_ss.add(files('accel.c'))
>
> -subdir('qtest')
> -subdir('kvm')
> subdir('tcg')
> -subdir('xen')
> -subdir('stubs')
> +if have_system
> + subdir('qtest')
> + subdir('kvm')
> + subdir('xen')
> + subdir('stubs')
> +endif
>
> dummy_ss = ss.source_set()
> dummy_ss.add(files(
>
Ciao Philippe,
I thought that the pattern used by Paolo was, recurse always, and put the check
inside the recursed dir meson.build .
Paolo did you indeed intend meson use this way?
Ciao,
Claudio