[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] qemu-option: warn for short-form boolean options
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH 2/2] qemu-option: warn for short-form boolean options |
|
Date: |
Mon, 09 Nov 2020 08:59:48 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 06/11/20 17:49, Markus Armbruster wrote:
>>> Deprecate all this, except for -chardev and -spice where it is in
>>> wide use.
>> I consider this a misuse of deprecation, to be frank. If something is
>> known to be unused, we just remove it. Deprecation is precisely for
>> things that are used. I'm with Daniel here: let's deprecate this sugar
>> everywhere.
>> Wide use may justify extending the deprecation grace period.
>
> Fair enough. However now that I think of it I'd have to remove the
> coverage of the "feature" in tests, because they'd warn.
Either that, or do what we do elsewhere when warnings get in the way of
testing: suppress them when testing. I wouldn't bother here unless it's
easy.