RE: [PATCH-for-5.2 2/5] hw/usb/Kconfig: Fix USB_XHCI_NEC (depends on USB_XHCI_PCI)

[Sai Pavan Boddu]

Thanks, good fix.

Reviewed-by: Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>

Regards,
Sai Pavan
> -----Original Message-----
> From: Philippe Mathieu-Daudé <philmd@redhat.com>
> Sent: Saturday, November 7, 2020 4:43 PM
> To: qemu-devel@nongnu.org
> Cc: Gerd Hoffmann <kraxel@redhat.com>; Sai Pavan Boddu
> <saipava@xilinx.com>; Philippe Mathieu-Daudé <philmd@redhat.com>
> Subject: [PATCH-for-5.2 2/5] hw/usb/Kconfig: Fix USB_XHCI_NEC (depends on
> USB_XHCI_PCI)
> 
> Since commit 755fba11fbc and 8ddab8dd3d8 we can not build USB_XHCI_NEC
> without USB_XHCI_PCI. Correct the Kconfig dependency.
> 
> Fixes: 755fba11fbc ("usb/hcd-xhci: Move qemu-xhci device to hcd-xhci-pci.c")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  hw/usb/Kconfig | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig index
> a674ce4c542..6a213b04758 100644
> --- a/hw/usb/Kconfig
> +++ b/hw/usb/Kconfig
> @@ -42,9 +42,7 @@ config USB_XHCI_PCI
> 
>  config USB_XHCI_NEC
>      bool
> -    default y if PCI_DEVICES
> -    depends on PCI
> -    select USB_XHCI
> +    select USB_XHCI_PCI
> 
>  config USB_XHCI_SYSBUS
>      bool
> --
> 2.26.2