Re: [PATCH v3 01/41] tcg: Enhance flush_icache_range with separate data pointer

[Alex Bennée]

Richard Henderson <richard.henderson@linaro.org> writes:

> On 11/6/20 12:31 PM, Alex Bennée wrote:
>>> +/* Flush the dcache at RW, and the icache at RX, as necessary. */
>>> +static inline void flush_idcache_range(uintptr_t rx, uintptr_t rw, size_t 
>>> len)
>>>  {
>>> -    __builtin___clear_cache((char *)start, (char *)stop);
>>> +    /* TODO: Copy this from gcc to avoid 4 loops instead of 2. */
>> 
>> Why not do it now?
>
> Do you really want to be including that into a patch that touches all host
> backends?  I do it later, in a change by itself.

Ahh I hadn't noticed. I was just thrown by the TODO and wondering what
it was.

>
>> I take it i386 is just too primitive to care about flushing things?
>
> Or the reverse.  ;-)
>
>
> r~


-- 
Alex Bennée