[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] hw/m68k/q800.c: Make the GLUE chip an actual QOM device
From: |
Laurent Vivier |
Subject: |
Re: [PATCH 2/2] hw/m68k/q800.c: Make the GLUE chip an actual QOM device |
Date: |
Sat, 7 Nov 2020 17:15:36 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 |
Le 07/11/2020 à 00:51, Peter Maydell a écrit :
> The handling of the GLUE (General Logic Unit) device is
> currently open-coded. Make this into a proper QOM device.
>
> This minor piece of modernisation gets rid of the free
> floating qemu_irq array 'pic', which Coverity points out
> is technically leaked when we exit the machine init function.
> (The replacement glue device is not leaked because it gets
> added to the sysbus, so it's accessible via that.)
>
> Fixes: Coverity CID 1421883
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/m68k/q800.c | 82 ++++++++++++++++++++++++++++++++++++++++++--------
> 1 file changed, 70 insertions(+), 12 deletions(-)
>
Reviewed-by: Laurent vivier <laurent@vivier.eu>