[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/1] Change the order of g_free(info) and tracepoint
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 1/1] Change the order of g_free(info) and tracepoint |
|
Date: |
Fri, 6 Nov 2020 17:57:15 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 |
On 11/6/20 4:59 PM, David Edmondson wrote:
> On Friday, 2020-11-06 at 19:09:24 +0530, Kirti Wankhede wrote:
>
>> Fixes Coverity issue:
>> CID 1436126: Memory - illegal accesses (USE_AFTER_FREE)
>>
>> Fixes: a9e271ec9b36 ("vfio: Add migration region initialization and finalize
>> function")
>>
>> Signed-off-by: Kirti Wankhede <kwankhede@nvidia.com>
>
> Maybe "fix use after free in vfio_migration_probe" as a summary?
Yes please :)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> Reviewed-by: David Edmondson <dme@dme.org>
>
>> ---
>> hw/vfio/migration.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c
>> index 3ce285ea395d..55261562d4f3 100644
>> --- a/hw/vfio/migration.c
>> +++ b/hw/vfio/migration.c
>> @@ -897,8 +897,8 @@ int vfio_migration_probe(VFIODevice *vbasedev, Error
>> **errp)
>> goto add_blocker;
>> }
>>
>> - g_free(info);
>> trace_vfio_migration_probe(vbasedev->name, info->index);
>> + g_free(info);
>> return 0;
>>
>> add_blocker:
>> --
>> 2.7.0
>
> dme.
>