Re: [PATCH v2 5/6] macio: don't reference serial_hd() directly within the device

[Mark Cave-Ayland]

On 05/11/2020 05:31, Thomas Huth wrote:

> > (goes and looks)
> >
> > Ah okay it appears to be because the object property link to the PIC is
> > missing, which is to be expected as it is only present on the Mac machines.
> >
> > With the latest round of QOM updates I can see the solution but it's
> > probably a bit much now that we've reached rc-0. The easiest thing for the
> > moment is to switch user_creatable back to false if this is causing an issue.
>
> +1 for setting user_creatable back to false ... can you send a patch or
> shall I prepare one?

No that's fine, I can come up with a fix over the next couple of days.

> > Just out of interest how did you find this? My new workflow involves a local
> > "make check" with all ppc targets and a pass through Travis-CI and it didn't
> > show up there for me (or indeed Peter's pre-merge tests).
>
> I've found it with the scripts/device-crash-test script. (You currently need
> to apply Eduardo's patch "Check if path is actually an executable file" on
> top first to run it)

Have you got a link for this? I've tried doing some basic searches in my email client 
and couldn't easily spot it...


ATB,

Mark.